Refactor Maket Page to use Aave-sdk #2686

AGMASO · 2025-09-29T10:40:01Z

General Changes

Refactored useAppDataProvider hook to use aave-sdk instead of direct RPC calls.
Markets page now relies on the SDK for reserves and incentives.

Developer Notes

For special tokens (e.g. PTs), the SDK pulls a generic image from the family API instead of the correct token. As a fallback, we still use fetchIconSymbolAndName in those cases.
Added a mapping layer to adapt SDK incentive structures to the legacy system, avoiding breaking the existing Incentives Cards logic.

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

End-to-end tests are passing without any errors
Code changes do not significantly increase the application bundle size
If there are new 3rd-party packages, they do not introduce potential security threats
If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

vercel · 2025-09-29T10:40:07Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
interface	Ready	Preview	Comment	Oct 21, 2025 10:52am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

github-actions · 2025-09-29T10:59:28Z

Ipfs hash: bafybeib76dlog6rsspwil6b5itmlzmsrhig6qr7tifbhhl7edfx77zpqrq
Ipfs preview link: https://bafybeib76dlog6rsspwil6b5itmlzmsrhig6qr7tifbhhl7edfx77zpqrq.ipfs.cf-ipfs.com/

github-actions · 2025-09-29T10:59:42Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-09-30T08:53:19Z

Ipfs hash: bafybeiepwhadsbftsxazww6y3bkkdfsuovsf2sp5vnn72hdas3tv7frax4
Ipfs preview link: https://bafybeiepwhadsbftsxazww6y3bkkdfsuovsf2sp5vnn72hdas3tv7frax4.ipfs.cf-ipfs.com/

github-actions · 2025-09-30T08:53:20Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

src/modules/markets/MarketAssetsList.tsx

github-actions · 2025-09-30T17:13:08Z

Ipfs hash: bafybeia7zujbt3fhpsuzgahybvrxeswrgradlii27ydiwgh6y3de3bl2fi
Ipfs preview link: https://bafybeia7zujbt3fhpsuzgahybvrxeswrgradlii27ydiwgh6y3de3bl2fi.ipfs.cf-ipfs.com/

github-actions · 2025-09-30T17:13:13Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mgrabina · 2025-09-30T17:36:27Z

new different default?

mgrabina · 2025-09-30T17:37:55Z

are we missing a market in the backend?

mgrabina

Something to double check as well is diff variable apy, maybe expected (e.g. apr vs apy) but safer to point in out in backend channel if the value is purely coming from there

src/components/incentives/incentives.helper.ts

src/hooks/app-data-provider/useAppDataProvider.tsx

src/modules/markets/MarketAssetsList.tsx

github-actions · 2025-10-10T10:56:26Z

Ipfs hash: bafybeigrgvou4vsy4ri6baj5iemkqbhe4ythl4rlpcdhgfsapzg4dl4rgu
Ipfs preview link: https://bafybeigrgvou4vsy4ri6baj5iemkqbhe4ythl4rlpcdhgfsapzg4dl4rgu.ipfs.cf-ipfs.com/

github-actions · 2025-10-10T10:56:39Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

foodaka · 2025-10-10T11:24:21Z

src/hooks/app-data-provider/useAppDataProvider.tsx

+        supplyReserves,
+        borrowReserves,
+        eModeCategories,
+        userState: marketUserState,


is this one used?

Actually not yet, but I have a feeling I’ll need it for another part of the Aave/interface refactoring. I can delete it for now if you’d like.

src/modules/markets/MarketAssetsListItem.tsx

github-actions · 2025-10-10T12:51:41Z

Ipfs hash: bafybeia3wueaqbcuezo2btccrvdit2zef3awzu7kx6vt2akynwfg4gbnfu
Ipfs preview link: https://bafybeia3wueaqbcuezo2btccrvdit2zef3awzu7kx6vt2akynwfg4gbnfu.ipfs.cf-ipfs.com/

github-actions · 2025-10-10T12:51:55Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-10-13T07:37:41Z

Ipfs hash: bafybeia35kcthgns7rcvasrovsd5iyjlanln766eypsix7dt7cmvi7ewza
Ipfs preview link: https://bafybeia35kcthgns7rcvasrovsd5iyjlanln766eypsix7dt7cmvi7ewza.ipfs.cf-ipfs.com/

github-actions · 2025-10-13T07:37:51Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-10-21T10:55:23Z

Ipfs hash: bafybeiefqolhkscdoviyvtip2y2sxg2d53utzzqrl7kpnjtvkhw24p5ibm
Ipfs preview link: https://bafybeiefqolhkscdoviyvtip2y2sxg2d53utzzqrl7kpnjtvkhw24p5ibm.ipfs.cf-ipfs.com/

github-actions · 2025-10-21T10:55:36Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

AGMASO added 3 commits September 26, 2025 16:05

refactor: sdk integrated in market page

114328f

chore: clean code

940cdf4

fix: simplified icon fetch logic & clean code

fcb1a39

AGMASO requested review from JoaquinBattilana, foodaka, grothem and mgrabina September 29, 2025 10:40

fix: build error

92eeffd

vercel bot had a problem deploying to Preview September 29, 2025 10:43 Failure

fix: build error

a80c04b

vercel bot deployed to Preview September 29, 2025 10:50 View deployment

fix: build error

4a5e1fe

vercel bot deployed to Preview September 29, 2025 10:54 View deployment

chore: clean code

eff6ed6

vercel bot deployed to Preview September 30, 2025 08:49 View deployment

mgrabina reviewed Sep 30, 2025

View reviewed changes

src/modules/markets/MarketAssetsList.tsx Outdated Show resolved Hide resolved

chore: clean code

8653eb9

AGMASO requested a review from mgrabina September 30, 2025 17:06

vercel bot deployed to Preview September 30, 2025 17:08 View deployment

mgrabina reviewed Oct 2, 2025

View reviewed changes

fix: show disabled only for > 0 amounts

be28f80

mgrabina reviewed Oct 9, 2025

View reviewed changes

fix: use typescript guards

d3d3e45

vercel bot deployed to Preview October 10, 2025 10:51 View deployment

foodaka reviewed Oct 10, 2025

View reviewed changes

src/modules/markets/MarketAssetsListItem.tsx Outdated Show resolved Hide resolved

AGMASO added 2 commits October 10, 2025 14:05

fix: simplified code

3610842

refactor: move incentives calculation to parent component

4e83b97

AGMASO requested review from foodaka and mgrabina October 10, 2025 12:45

vercel bot deployed to Preview October 10, 2025 12:47 View deployment

mgrabina previously approved these changes Oct 10, 2025

View reviewed changes

chore: clean code

de6b877

AGMASO dismissed mgrabina’s stale review via de6b877 October 13, 2025 07:30

vercel bot deployed to Preview October 13, 2025 07:32 View deployment

AGMASO requested a review from mgrabina October 13, 2025 07:35

feat: added Pts-ethena tokens to mapping

f8fa340

vercel bot had a problem deploying to Preview October 21, 2025 10:44 Failure

chore: trigger rebuild

5b6f0ee

vercel bot deployed to Preview October 21, 2025 10:52 View deployment

foodaka approved these changes Oct 21, 2025

View reviewed changes

foodaka merged commit 08b1677 into main Oct 21, 2025
19 of 21 checks passed

foodaka deleted the refactor/sdk-in-markets branch October 21, 2025 11:06

Uh oh!

Refactor Maket Page to use Aave-sdk #2686

Refactor Maket Page to use Aave-sdk #2686

Uh oh!

Conversation

AGMASO commented Sep 29, 2025

General Changes

Developer Notes

Reviewer Checklist

Uh oh!

vercel bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

mgrabina commented Sep 30, 2025

Uh oh!

mgrabina commented Sep 30, 2025

Uh oh!

mgrabina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

foodaka Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

AGMASO Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel bot commented Sep 29, 2025 •

edited

Loading

AGMASO Oct 10, 2025 •

edited

Loading